Skip to content

Add QtQuickControls module to cxx-qt-lib, expose QQuickStyle #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2024
Merged

Add QtQuickControls module to cxx-qt-lib, expose QQuickStyle #966

merged 1 commit into from
Jun 14, 2024

Conversation

redstrate
Copy link
Contributor

This is used to control which Quick Controls style is used in the application. This is part of the Quick Controls API and requires the QuickControls2 Qt module, so it's separated into another folder in cxx-qt-lib.

Example:

QQuickStyle::setStyle(&QString::from("Basic"));
QQuickStyle::setFallbackStyle(&QString::from("Material"));
println!("Style name: {}", QQuickStyle::name());

This is a pretty common pattern in KDE applications, and a pretty low-hanging fruit.

@redstrate redstrate requested a review from ahayzen-kdab May 30, 2024 21:13
@redstrate redstrate self-assigned this May 30, 2024
@redstrate redstrate force-pushed the wip/josh/qtquickcontrols branch 3 times, most recently from 41c02f5 to 8eb01d3 Compare May 30, 2024 21:21
@ahayzen-kdab
Copy link
Collaborator

@redstrate Looks great, CI is failing on Windows with a linker issue. Looks maybe related to the tests though, could you try adding a test to qt-types-standalone and in the CMake ensure it links to QuickControls maybe that'll help ?

ahayzen-kdab
ahayzen-kdab reviewed May 31, 2024
View reviewed changes
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the wip/josh/qtquickcontrols branch from 8eb01d3 to beae41a Compare June 5, 2024 10:17
@LeonMatthesKDAB
Copy link
Collaborator

@redstrate I've rebased the branch so CI should pass again now 🤞

@redstrate redstrate force-pushed the wip/josh/qtquickcontrols branch 3 times, most recently from ee2314e to 5dfe191 Compare June 7, 2024 16:56
@redstrate
Add QtQuickControls module to cxx-qt-lib, expose QQuickStyle
1968597 
This is used to control which Quick Controls style is used in the
application. This is part of the Quick Controls API and requires the
QuickControls2 Qt module, so it's separated into another folder in
cxx-qt-lib.
@redstrate redstrate force-pushed the wip/josh/qtquickcontrols branch from 5dfe191 to 1968597 Compare June 7, 2024 17:18
@redstrate
Copy link
Contributor Author

@redstrate Looks great, CI is failing on Windows with a linker issue. Looks maybe related to the tests though, could you try adding a test to qt-types-standalone and in the CMake ensure it links to QuickControls maybe that'll help ?

Most of the CI works now, except for Windows. I'm guessing the QtQuickControls dll is missing from the bin folder, is there something I need to manually change to make that work?

@LeonMatthesKDAB
Copy link
Collaborator

@redstrate I think these failures are unrelated to your changes.
the nightly builds also have started to fail in the last days, without any code changes.

I can also observe similar failures on https://github.com/kdab/knut and https://github.com/kdab/kdbindings.

Also, I bet if we build our CI in debug mode it's suddenly going to work again...

@LeonMatthesKDAB LeonMatthesKDAB merged commit cd59f30 into main Jun 14, 2024
20 checks passed
@LeonMatthesKDAB LeonMatthesKDAB deleted the wip/josh/qtquickcontrols branch June 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab left review comments

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees

@redstrate redstrate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redstrate @ahayzen-kdab @LeonMatthesKDAB